Skip to content

#66: Add Human-readable description of MessageId object #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

erichare
Copy link
Contributor

@BewareMyPower sorry this took so long, got distracted by some other things. I didn't realize this was already implemented in the C++ client .... at least if i'm not crazy :) So basically I just pulled a binding (same as the str binding) for repr, and now the MessageId object looks like the following. Is this sufficient for purposes of this task?
Screenshot 2023-02-14 at 12 40 20 PM

@BewareMyPower BewareMyPower added this to the 3.2.0 milestone Feb 15, 2023
@BewareMyPower BewareMyPower added the enhancement New feature or request label Feb 15, 2023
@BewareMyPower BewareMyPower merged commit ed6983b into apache:main Feb 15, 2023
@erichare erichare deleted the #66 branch February 15, 2023 03:06
@BewareMyPower BewareMyPower modified the milestones: 3.2.0, 3.1.0 Feb 16, 2023
BewareMyPower pushed a commit that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants