-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[WIP][fix][broker] Fix corrupted topic policies issues with sequential topic policy updates #24427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhotari
wants to merge
17
commits into
apache:master
Choose a base branch
from
lhotari:lh-fix-topic-policy-mutations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
4 tasks
…space gets removed
…n in reference counting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24427 +/- ##
============================================
+ Coverage 73.57% 74.27% +0.69%
- Complexity 32624 32750 +126
============================================
Files 1877 1869 -8
Lines 139502 145392 +5890
Branches 15299 16683 +1384
============================================
+ Hits 102638 107987 +5349
+ Misses 28908 28836 -72
- Partials 7956 8569 +613
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24393
Fixes #21303
Motivation
There's a long time issue where topic policies get corrupted as a result of sequential or concurrent topic policy updates.
Modifications
Fixing the issue requires changing the TopicPoliciesService interface. This PR contains the initial changes.
"PIP-428: Change TopicPoliciesService interface to fix consistency issues" (#24428) covers the broader context.
Documentation
doc
doc-required
doc-not-needed
doc-complete