Skip to content

[Enhancement] Handle namespace outside the loop #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
mawen12 opened this issue Nov 5, 2024 · 0 comments · Fixed by #8890
Closed
1 task done

[Enhancement] Handle namespace outside the loop #8889

mawen12 opened this issue Nov 5, 2024 · 0 comments · Fixed by #8890

Comments

@mawen12
Copy link
Contributor

mawen12 commented Nov 5, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

The variable namespace has no relations with foreach, so i think handle it outside the loop is better.

Motivation

namespace doesn't need to repeat check, it only need get and check once.

Describe the Solution You'd Like

Handle namespace outside the loop.

Describe Alternatives You've Considered

No.

Additional Context

No response

RongtongJin pushed a commit that referenced this issue Nov 8, 2024
* handle namespace outside the loop

* fix checkstyle check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant