Skip to content

[ISSUE #8829] Keep data version while reload and XXXConfigManagerV2 turns off sync #8891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[ISSUE #8829] Keep data version while reload and XXXConfigManagerV2 turns off sync #8891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions broker/src/main/java/org/apache/rocketmq/broker/config/v2/ConfigStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ protected void initOptions() {
protected void initAbleWalWriteOptions() {
this.ableWalWriteOptions = new WriteOptions();

// For metadata, prioritize data integrity
this.ableWalWriteOptions.setSync(true);
// Given that fdatasync is kind of expensive, sync-WAL for every write cannot be afforded.
this.ableWalWriteOptions.setSync(false);

// We need WAL for config changes
this.ableWalWriteOptions.setDisableWAL(false);
Expand Down
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/config/v2/SubscriptionGroupManagerV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ private boolean loadSubscriptions() {
while (iterator.isValid()) {
SubscriptionGroupConfig subscriptionGroupConfig = parseSubscription(iterator.key(), iterator.value());
if (null != subscriptionGroupConfig) {
super.updateSubscriptionGroupConfigWithoutPersist(subscriptionGroupConfig);
super.putSubscriptionGroupConfig(subscriptionGroupConfig);
}
iterator.next();
}
Expand Down
2 changes: 1 addition & 1 deletion broker/src/main/java/org/apache/rocketmq/broker/config/v2/TopicConfigManagerV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private boolean loadTopicConfig() {
byte[] value = iterator.value();
TopicConfig topicConfig = parseTopicConfig(key, value);
if (null != topicConfig) {
super.updateSingleTopicConfigWithoutPersist(topicConfig);
super.putTopicConfig(topicConfig);
}
iterator.next();
}
Expand Down
Loading