[ISSUE #8979] Add configurable switch for timer message retry logic #8980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8980 +/- ##
==========================================
Coverage 47.70% 47.70%
- Complexity 11782 11785 +3
==========================================
Files 1304 1304
Lines 91188 91218 +30
Branches 11713 11718 +5
==========================================
+ Hits 43502 43517 +15
- Misses 42315 42319 +4
- Partials 5371 5382 +11 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Nov 26, 2024
| } | ||
| return PUT_NO_RETRY; | ||
| return PUT_NEED_RETRY; | ||
| } | ||
|
|
||
| public MessageExtBrokerInner convertMessage(MessageExt msgExt, boolean needRoll) { |
There was a problem hiding this comment.
It would be beneficial to include a unit test
There was a problem hiding this comment.
I’ve added a unit test to cover this function. Please take a look👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8979
Brief Description
TimerEnableRetryUntilSuccessto control retry behavior.TimerEnableRetryUntilSuccessis disabled, a message will be retried up to 3 times before being discarded.