Skip to content

[ISSUE #9187] The request should be rejected if the queueOffset equals maxOffset when changing the invisible time #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Feb 17, 2025

Which Issue(s) This PR Fixes

Fixes #9187

Brief Description

When changing the invisible time, the request should be rejected if the queueOffset equals maxOffset

How Did You Test This Change?

@RongtongJin RongtongJin changed the title When changing the invisible time, the request should be rejected if the queueOffset equals maxOffset [ISSUE #9187] The request should be rejected if the queueOffset equals maxOffset when changing the invisible time Feb 17, 2025
fuyou001
fuyou001 previously approved these changes Feb 17, 2025
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin marked this pull request as draft February 17, 2025 09:44
@RongtongJin RongtongJin marked this pull request as ready for review February 17, 2025 10:19
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.05%. Comparing base (295821b) to head (d4b0a8b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...broker/processor/ChangeInvisibleTimeProcessor.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9186      +/-   ##
=============================================
- Coverage      48.13%   48.05%   -0.08%     
+ Complexity     12104    12089      -15     
=============================================
  Files           1321     1321              
  Lines          93033    93030       -3     
  Branches       11924    11923       -1     
=============================================
- Hits           44777    44709      -68     
- Misses         42737    42789      +52     
- Partials        5519     5532      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ltamber ltamber merged commit 6cccff8 into apache:develop Feb 19, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants