Skip to content

[ISSUE #8701] Fix documentation for brokerAddrTable property in MQClientInstance.java #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DivyanshIITB
Copy link
Contributor

@DivyanshIITB DivyanshIITB commented Mar 19, 2025

Clarified that the key of the brokerAddrTable map is the brokerName, not brokerClusterName, to prevent ambiguity.
Closes #8701

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.06%. Comparing base (2219fd8) to head (04988c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9263   +/-   ##
==========================================
  Coverage      48.05%   48.06%           
- Complexity     12097    12099    +2     
==========================================
  Files           1322     1322           
  Lines          93127    93127           
  Branches       11940    11940           
==========================================
+ Hits           44752    44758    +6     
+ Misses         42831    42822    -9     
- Partials        5544     5547    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DivyanshIITB
Copy link
Contributor Author

Just a gentle reminder
@RongtongJin

@RongtongJin RongtongJin changed the title Fix documentation for brokerAddrTable property in MQClientInstance.java [ISSUE #8701] Fix documentation for brokerAddrTable property in MQClientInstance.java Mar 20, 2025
@RongtongJin
Copy link
Contributor

LGTM~

@RongtongJin RongtongJin merged commit 27c2916 into apache:develop Mar 20, 2025
10 of 11 checks passed
DivyanshIITB added a commit to DivyanshIITB/rocketmq that referenced this pull request Mar 20, 2025
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Description of the brokerAddrTable property in MQClientInstance
3 participants