Skip to content

[ISSUE #7948] Prevent invoking the queryMessage method lead to OOM #9265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

yangxiaohui-coll
Copy link
Contributor

@yangxiaohui-coll yangxiaohui-coll commented Mar 20, 2025

Which Issue(s) This PR Fixes

Fixes #7948

Brief Description

Adjust the creation location of the phyOffsets

How Did You Test This Change?

Write necessary unit-test

RongtongJin
RongtongJin previously approved these changes Mar 22, 2025
@RongtongJin RongtongJin changed the title [Bug] Calling queryMessage rocketmq may pose an OOM risk #7948 [ISSUE #7948] Calling queryMessage rocketmq may pose an OOM risk #7948 Mar 22, 2025
@RongtongJin
Copy link
Contributor

LGTM~

@RongtongJin
Copy link
Contributor

IndexServiceTest is missing ASF header

@yangxiaohui-coll
Copy link
Contributor Author

Okay, I have added ASF header

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.02%. Comparing base (34c32d8) to head (f4c90ff).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9265      +/-   ##
=============================================
- Coverage      48.16%   48.02%   -0.14%     
+ Complexity     12124    12101      -23     
=============================================
  Files           1322     1322              
  Lines          93126    93126              
  Branches       11940    11940              
=============================================
- Hits           44850    44720     -130     
- Misses         42738    42866     +128     
- Partials        5538     5540       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #7948] Calling queryMessage rocketmq may pose an OOM risk #7948 [ISSUE #7948] Prevent invoking the queryMessage method lead to OOM risk #7948 Mar 26, 2025
@lizhimins lizhimins changed the title [ISSUE #7948] Prevent invoking the queryMessage method lead to OOM risk #7948 [ISSUE #7948] Prevent invoking the queryMessage method lead to OOM #7948 Mar 26, 2025
@lizhimins lizhimins changed the title [ISSUE #7948] Prevent invoking the queryMessage method lead to OOM #7948 [ISSUE #7948] Prevent invoking the queryMessage method lead to OOM Mar 26, 2025
@lizhimins lizhimins merged commit 62be041 into apache:develop Mar 26, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Calling queryMessage rocketmq may pose an OOM risk
4 participants