Skip to content

Avoid NPE for handling client settings null in notifyClientTermination #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

lollipopjin
Copy link
Contributor

Which Issue(s) This PR Fixes

Avoid NPE for handling client settings null in notifyClientTermination

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (586a274) to head (f5103b7).

Files with missing lines Patch % Lines
.../rocketmq/proxy/grpc/v2/client/ClientActivity.java 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9308      +/-   ##
=============================================
- Coverage      48.12%   48.06%   -0.06%     
+ Complexity     12140    12118      -22     
=============================================
  Files           1322     1322              
  Lines          93237    93242       +5     
  Branches       11957    11958       +1     
=============================================
- Hits           44868    44816      -52     
- Misses         42830    42881      +51     
- Partials        5539     5545       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 445b945 into apache:develop Apr 2, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants