Skip to content

[ISSUE #9369] Fix reset offset commit pull offset when use pop consumer service #9370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #9369

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.08%. Comparing base (7ef3610) to head (325884f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/broker/processor/AdminBrokerProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9370      +/-   ##
=============================================
- Coverage      48.20%   48.08%   -0.12%     
+ Complexity     12167    12135      -32     
=============================================
  Files           1323     1323              
  Lines          93426    93440      +14     
  Branches       12010    12010              
=============================================
- Hits           45032    44932     -100     
- Misses         42839    42942     +103     
- Partials        5555     5566      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 3c2e81d into apache:develop Apr 28, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix reset offset commit pull offset when use pop consumer service
4 participants