Skip to content

[ISSUE #9233] Fix query time boundary calculation in tiered storage #9374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9233

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (854369a) to head (6ae0f65).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
.../rocketmq/tieredstore/index/IndexStoreService.java 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9374      +/-   ##
=============================================
+ Coverage      48.04%   48.06%   +0.01%     
+ Complexity     12142    12131      -11     
=============================================
  Files           1323     1323              
  Lines          93395    93441      +46     
  Branches       11997    12009      +12     
=============================================
+ Hits           44875    44911      +36     
+ Misses         42971    42951      -20     
- Partials        5549     5579      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 6819b4d into apache:develop Apr 29, 2025
10 of 11 checks passed
@bxfjb
Copy link
Contributor

bxfjb commented May 6, 2025

It looks like this pr revert the #9234, just to be clear, is there any reason? @lizhimins @dingshuangxi888 : )

3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Querying message in tiered storage may fail due to small time scope
4 participants