Skip to content

Refactor predis plugin to hook Client. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2023
Merged

Refactor predis plugin to hook Client. #68

merged 2 commits into from
Apr 17, 2023

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Apr 16, 2023 •
edited
Loading

  1. Previous the predis plugin hook the AbstractConnection.executeCommand method, which is too low level, it doesn't look good on the display as endpoint, now change to hook Client.<OP>.
  2. To adapt old version predis, so not mark getting not-exists key error.

@jmjoy jmjoy added this to the 0.5.0 milestone Apr 16, 2023
@jmjoy jmjoy marked this pull request as ready for review April 17, 2023 05:29
@jmjoy jmjoy requested a review from wu-sheng April 17, 2023 05:29
@wu-sheng wu-sheng merged commit b74b362 into apache:master Apr 17, 2023
@jmjoy jmjoy deleted the jmjoy/predis branch April 17, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jmjoy @wu-sheng