[SPARK-42329][SQL]Assign name to _LEGACY_ERROR_TEMP_2256 #51113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailom-db
reviewed
Jun 8, 2025
| @@ -1775,6 +1775,12 @@ | |||
| ], | |||
| "sqlState" : "39000" | |||
| }, | |||
| "FOREACH_WRITER_ABORTED" : { | |||
| "message" : [ | |||
| "Foreach writer has been aborted due to a task failure." | |||
There was a problem hiding this comment.
Could we take a look at adding a hint for the user on how to actually overcome this issue? Is it possible to point to which task failed or what could prevent it to fail?
There was a problem hiding this comment.
hi @mihailom-db , sure. I actually thought about it while renaming, but at that point I was not sure whether it's a good idea to change the msg (exposed to the user) in one commit. Since you also mentioned, I'll just do it ;)
There was a problem hiding this comment.
hi @mihailom-db I did an update, please take a look. Unfortunately, it can only capture error detail during Write now. if the exception is thrown from earlier stage, but abort during Write, then the error detail can't be captured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
see https://issues.apache.org/jira/browse/SPARK-42329. Assign a meaningful name to error _LEGACY_ERROR_TEMP_2256.
Why are the changes needed?
see https://issues.apache.org/jira/browse/SPARK-42329
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT, there's an existing UT.
Was this patch authored or co-authored using generative AI tooling?
No