[SPARK-52423][CONNECT] Add missing golang package name to pipelines.proto #51126
Conversation
|
Could you create a Jira ticket for this? |
Sure can do this. I was just trying to avoid the overhead of creating a JIRA ticket that needs 5 lines of descriptions for a one line change. |
grundprinzip
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
HyukjinKwon
changed the title
HyukjinKwon
changed the title
Adhoc refers to an ad-hoc change, similar to [MINOR] or [FIX] etc. |
|
It would be great to merge this into the 4.0 branch for the next maintenance release. This way dependencies using the release branches will receive the update as well. WDYT? |
|
|
|
Thanks! I regenerated the Python files. I didn't expect the Python files referencing the Go package. |
|
merging to master and 4.0 |
Has it really been merged? I couldn't find SPARK-52423 in the commit log of the master |
|
No, I wasn't able to merge it because of conflicts in 4.0. Will merge to master only and then cherry-pick to 4.0. |
…roto The newly added `pipelines.proto` file is missing the golang package identifier that is needed for the Spark Connect Go client. Spark 4.0 compatibility No Manually tested as part of apache/spark-connect-go#142. No Closes apache#51126 from grundprinzip/missing-golang-package. Authored-by: Martin Grund <[email protected]> Signed-off-by: Martin Grund <[email protected]>
|
Actually, the pipelines proto is not part of 4.0, so this is not a problem. |
What changes were proposed in this pull request?
The newly added
pipelines.protofile is missing the golang package identifier that is needed for the Spark Connect Go client.Why are the changes needed?
Spark 4.0 compatibility
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually tested as part of apache/spark-connect-go#142.
Was this patch authored or co-authored using generative AI tooling?
No