feat(time_comparison): Support all date formats when computing custom and inherit offsets #30002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
- Support Human readable dates in the label and data call - Handling inherit and dates as time_offsets in the backend
- Today date must be set to 00:00 so round doesnt affect calculation of the shift
- Use different cache keys based on new offsets supported
- Render label when coming from inherit to custom without error - Custom date must not set hour to 00:00
- Pylint fix
- Support other formats when entering dates
- Stop processing offsets in the frontend for custom or inherit and instead use the backend so we avoid limitations on date formats and human readable - If offset is a predefined one (not custom nor inherit) do not compute the offset sine it's the same value - No need to add extra date formats when computing the offset now since it is always calle dafter parsing the date
- Mypy fix
Antonio-RiveroMartnez
force-pushed
the
time_comparison_zeros
branch
from
c825aca to
5255dde
Compare
kgabryje
reviewed
Aug 23, 2024
| ensureIsArray(customOrInheritShifts).includes('inherit') | ||
| ) { | ||
| return fetchTimeRange(filter.comparator, filter.subject).then(res => { | ||
| const datePattern = /\d{4}-\d{2}-\d{2}/g; |
There was a problem hiding this comment.
Can we move it to a const, since we’re using it in many files?
- Add constant we can reuse for our date pattern
michael-s-molina
added
review:checkpoint
nyohasstium
pushed a commit
to Webgains/superset
that referenced
this pull request
Jan 2, 2025
… and inherit offsets (apache#30002)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The time comparison feature that's being used in Table and Big Number charts does not support Human Readable dates and it's very limited on what date formats it supports.
Now the API supports sending
inheritor aYYYY-MM-DDdate as offset value so we can rely on the existing API to parse any date before computing the custom or inherit offset.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
Now
TESTING INSTRUCTIONS
Aug 2024until `tomorrow``ADDITIONAL INFORMATION