fix(filters modal): layout cleanup, simplification, fixes #31448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
change:frontend
rusackas
requested review from
michael-s-molina,
justinpark,
kgabryje,
geido,
mistercrunch and
Vitor-Avila
|
/testenv up |
|
@sadpandajoe Processing your ephemeral environment request here. |
|
@sadpandajoe Ephemeral environment spinning up at http://54.190.59.231:8080. Credentials are |
mistercrunch
approved these changes
Dec 14, 2024
kgabryje
reviewed
Dec 16, 2024
...et-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
Outdated
Show resolved
Hide resolved
rusackas
requested review from
jinghua-qa,
eschutho and
betodealmeida
as code owners
|
/korbit-review |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this rooster.
\\
(o>
\\_//)
\_/_)
_|_Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigurePane.tsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx | ✅ |
| superset-frontend/src/components/Modal/Modal.tsx | ✅ |
| superset-frontend/cypress-base/cypress/support/directories.ts | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx | ✅ |
| superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The new Add Filter/Divider buttons were getting hidden when the browser window was too short. "But it's flexbox, that shouldn't happen" I said. Then I started looking at all the onion layers of styled divs with random heights and overrides.
This PR cleans a bunch of junk up. There are fewer elements now, a few unnecessary overrides and styles are taken out, and things generally use more flexbox-native layouts. I could keep trimming until the cows come home, but I wanted to stop when the problem was fixed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Video demo with narration:
https://github.com/user-attachments/assets/1ebaab79-71bc-40e5-975e-d09b77bf75e6
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION