chore: update sqlglot dialect map #33701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
update-dialects
branch
from
fb0c430 to
b5ade6f
Compare
Vitor-Avila
reviewed
Jun 5, 2025
| "mssql": Dialects.TSQL, | ||
| "mysql": Dialects.MYSQL, | ||
| "netezza": Dialects.POSTGRES, | ||
| "oceanbase": Dialects.MYSQL, |
There was a problem hiding this comment.
I think this should be ok, googled it and it seems they're aiming for a perfect replacement for MySQL so it should be fully compatible, but who knows 🤷 Don't think it would hold the PR just mentioning
There was a problem hiding this comment.
Yeah, that's my understanding. I think that even if these are not perfect matches it's better than using the generic parser.
Vitor-Avila
reviewed
Jun 5, 2025
| # "ocient": ??? | ||
| # "odelasticsearch": ??? | ||
| "oracle": Dialects.ORACLE, | ||
| "parseable": Dialects.POSTGRES, |
Vitor-Avila
approved these changes
Jun 5, 2025
ianngech
pushed a commit
to Pesapal-Ltd/superset
that referenced
this pull request
Jun 10, 2025
LevisNgigi
pushed a commit
to LevisNgigi/superset
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the DB engine spec -> sqlglot dialect map.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION