Restoration of Pre-FED Privacy Test Code #2139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - thanks for the patch @min-guk. During the merge, I picked the fedplanner tests, adapted their implementation so they succeed, enabled them in the github actions. |
|
Thank you. I will take a look at the revisions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code for FED Privacy, which was previously removed in commit d9822ce, has been restored. Moving forward, we plan to implement FED Privacy features incrementally in a bottom-up approach and aim to pass each of these test cases one by one as the functionality is developed.
@Ignoreannotation for the tests, all restored test code has been commented out to avoid build or runtime issues.This pull request focuses solely on restoring the test code for future development and testing purposes.