-
Notifications
You must be signed in to change notification settings - Fork 500
[SYSTEMDS-3874] Java17 Vectorized LibMM #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds vectorized kernels for matrix multiplication. fix mm error Perf mm bigger scale remove compile log
The results show that the vector api improve performance, for single threaded execution our AMD box improve by ~80% and Intel ~60% for dense mm. These improvements, are with allocation overhead of the output, and in ideal cases where the input are cached properly, and the JIT compilation is done. --- The failing tests are related to some sparse kernels with wrong results, will be fixed shortly. Script to evaluate mm performance:
After:
Before:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=========================================
Coverage 72.94% 72.95%
- Complexity 46061 46076 +15
=========================================
Files 1479 1479
Lines 172576 172613 +37
Branches 33776 33783 +7
=========================================
+ Hits 125893 125928 +35
- Misses 37186 37194 +8
+ Partials 9497 9491 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains code for vectorized MM It further include some vectorized instructions for CLA.