-
Notifications
You must be signed in to change notification settings - Fork 346
Migrate dynamic scripted Grafana Dashboards to Scenes #7927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jhg03a I also updated the Dockerfile of Grafana, I think you can give me some reviews |
infrastructure/cdn-in-a-box/optional/grafana/datasources.yml.template
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/.gitignore
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/.eslintrc
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/.prettierrc.js
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/LICENSE
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/README.md
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/img/logo.svg
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/tsconfig.json
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/components/App/App.tsx
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/.eslintrc.json
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/constants.ts
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/img/logo.svg
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/src/utils/utils.plugin.ts
Outdated
Show resolved
Hide resolved
infrastructure/cdn-in-a-box/optional/grafana/trafficcontrol-scenes/webpack/webpack.config.ts
Outdated
Show resolved
Hide resolved
update build specs Traffic Control Scenes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine on GitHub. I'll carve out some time tomorrow to try to spin it up and see how it actually works (#5939 permitting).
Did you finish with checking? |
Sorry, no, I got busy. And then... I forgot 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to work in its own right, but even after rebasing I can't get Docker to realize the builder on this branch is newer than the one it can pull. So I'm hoping merging it to master just solves that by publishing a new builder image. If it doesn't, for some reason, CiaB runs may be broken until it's resolved (locally, in all likelihood CI would be unaffected in this scenario) - although the project itself is still buildable if done from actual scratch. I think that's unlikely to happen, but excited to find out for sure.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Check the images below
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist