-
-
Notifications
You must be signed in to change notification settings - Fork 921
fix(symfony): fix swagger config to support Symfony ConfigBuilders #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(symfony): fix swagger config to support Symfony ConfigBuilders #4691
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@soyuka would you please check this PR? |
@soyuka, is any chance to merge this? |
@vincentchalamon probably has a better idea then me of the impacts of this |
Hi @alexndlm, Thanks for your PR. I've tested it in an API Platform project, but can't find any difference in the generated values comparing with the actual code, both dump me the following configuration:
Can you explain why the use of |
bb88c52
to
5053f69
Compare
@vincentchalamon, thanks that you check this PR. I have updated the tests and rebased PR on 2.7. This issue is only present with Symfony PHP ConfigBuilders. Now Symfony generates the following Config Class: And it is not possible to specify the authorization name: |
Thanks for the clear clarification 😃 |
036f83f
to
955b948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad commitlint (easy to fix), otherwise 👍
Good job @alexndlm!
Good job @alexndlm, thanks! |
Please see https://symfony.com/doc/current/configuration.html#using-php-configbuilders and https://symfony.com/doc/current/components/config/definition.html#array-node-options