fix(laravel): fixes to secure a graphql endpoint #6691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/middleware
branch
5 times, most recently
from
8ee5f60 to
9ce74cc
Compare
soyuka
commented
Oct 4, 2024
| @@ -936,51 +940,6 @@ public function register(): void | |||
| ); | |||
| }); | |||
|
|
|||
| if ($this->app['config']->get('api-platform.graphql.enabled')) { | |||
There was a problem hiding this comment.
it's not good to read configuration inside the register method as it may change when boot is called
soyuka
commented
Oct 4, 2024
| $app->make(CallableProcessor::class), | ||
| ); | ||
| }); | ||
|
|
||
| $app->singleton(ResolverFactoryInterface::class, function (Application $app) { | ||
| return new ResolverFactory( | ||
| $app->make('api_platform.graphql.state_provider'), | ||
| $app->make('api_platform.graphql.state_provider.access_checker'), |
There was a problem hiding this comment.
@vinceAmstoutz I splitted the system providers for Laravel!
There was a problem hiding this comment.
@soyuka 🎉 Can we prepare documentation now and merge it when your PR will be merged?
soyuka
commented
Oct 4, 2024
| if (isset($values[$parsedKey[0]])) { | ||
| $values = $values[$parsedKey[0]]; | ||
|
|
||
| if ($filter instanceof FilterInterface) { |
There was a problem hiding this comment.
at some point this will get deprecated
dunglas
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @toitzi reported GraphQl endpoints had no way to be secured. After a few messages we decided to introduce a new configuration option:
This gives the ability to plugin in a global auth middleware and to use Policies with GraphQl operations.