Skip to content

fix(symfony): internal resources should not inherit global defaults #7073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 11, 2025
Merged

fix(symfony): internal resources should not inherit global defaults #7073

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1b4ba8
fix: errors should not inherit default security
Crovitche-1623 Apr 10, 2025
70008ea
chore: add a polyfill for `array_any`
Crovitche-1623 Apr 10, 2025
39169e4
fix(symfony): don't add global defaults for internal resources instead
Crovitche-1623 Apr 10, 2025
96dbb71
chore: fix cs
Crovitche-1623 Apr 10, 2025
b9a9868
chore: fix cs
Crovitche-1623 Apr 10, 2025
c78ea74
fix(symfony): don't add global defaults for internal resources
Crovitche-1623 Apr 10, 2025
10b78f6
chore: revert polyfill because `array_any` is no longer used
Crovitche-1623 Apr 10, 2025
d4ff377
chore: fix cs
Crovitche-1623 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Metadata/Resource/Factory/OperationDefaultsTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use ApiPlatform\Metadata\ApiResource;
use ApiPlatform\Metadata\CollectionOperationInterface;
use ApiPlatform\Metadata\Delete;
use ApiPlatform\Metadata\Error;
use ApiPlatform\Metadata\Exception\RuntimeException;
use ApiPlatform\Metadata\Get;
use ApiPlatform\Metadata\GetCollection;
Expand All @@ -32,6 +33,7 @@
use ApiPlatform\Metadata\Post;
use ApiPlatform\Metadata\Util\CamelCaseToSnakeCaseNameConverter;
use ApiPlatform\State\CreateProvider;
use ApiPlatform\Validator\Exception\ValidationException;
use Psr\Log\LoggerInterface;

trait OperationDefaultsTrait
Expand All @@ -42,6 +44,11 @@ trait OperationDefaultsTrait

private function addGlobalDefaults(ApiResource|Operation $operation): ApiResource|Operation
{
// Do not add global defaults for internal resources:
if (\in_array($operation->getClass(), [Error::class, ValidationException::class], true)) {
return $operation;
}

$extraProperties = $this->defaults['extra_properties'] ?? [];

foreach ($this->defaults as $key => $value) {
Expand Down
Loading