fix(state): update generic template type variable in ProviderInterface #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Apr 11, 2025
| @@ -20,7 +20,7 @@ | |||
| /** | |||
| * Retrieves data from a persistence layer. | |||
| * | |||
| * @template T of object | |||
| * @template T of object|array | |||
There was a problem hiding this comment.
shouldn't it be iterable instead of array ?
There was a problem hiding this comment.
in fact, no, it's not an iterable, as it's really an array of compound data.
Like, in my case, in Doctrine Orm, I have a DQL query like SELECT o, some_scalar as somevalue ... which produce an array with the object/entity in the first array element, and the scalar in 'somevalue' array element.
So it's not an iterable.
change array to iterable
This reverts commit c190b24.
This was referenced Apr 15, 2025
|
reverted, see this comment for explanation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual phpDoc
@templatedefinition does not allow the provider to return arrays (like Doctrine mixed results).This tiny PR avoid PHPStan (and probably Psalms too) to throw some errors like the following
This was initially a feedback by @nesl247 for Psalm and not really fixed by #5024