ci: symfony 7.3 deprecations #7192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
reviewed
Jun 4, 2025
| @@ -153,13 +154,23 @@ public function testNormalizeCircularReference(): void | |||
|
|
|||
| $normalizer->setSerializer($this->prophesize(SerializerInterface::class)->reveal()); | |||
|
|
|||
| // Symfony >= 7.3 | |||
| $splObject = class_exists(EventStreamResponse::class) ? spl_object_id($circularReferenceEntity) : spl_object_hash($circularReferenceEntity); | |||
There was a problem hiding this comment.
Without any distinction between the new spl_object_id reference (Sf 7.3) vs the old spl_object_hash, if the test passes I doubt that a circular reference case will actually be tested.
BTW when i found this i wondered it it wasn't a BC of the serializer component even if it's basically something internal to it.
There was a problem hiding this comment.
Yes this is my bad it's just that we fixed most of the deprecations on main so I just got the file from there. I'll reapply your patch. And yeah the old code wasn't really necessary anymore.
soyuka
force-pushed
the
fix/73-deprecs
branch
3 times, most recently
from
498649d to
b74d4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're mostly ignoring issues related to TypeInfo as we already took care of this on the main branch.