Instantiate one CachedFetcher per gateway instance #3704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In its current state, the gateway uses a global fetcher, meaning the fetcher and its cache is shared among all gateways within the same runtime. This change attaches a single fetcher to the instance of the gateway and utilizes its own fetcher for all requests to GCS. The global fetcher was fortunately not depended on by anything else, so the change is relatively minimal. I made a few consolidations so as not to pass the fetcher around between many small functions. The functions I removed were one-time use, relatively small, and may have added negligible amounts of indirection anyway.
Co-Authored-By: Jesse Rosenberger <[email protected]>
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…llo-server#3704) In its current state, the gateway uses a global fetcher, meaning the fetcher and its cache is shared among all gateways within the same runtime. This change attaches a single fetcher to the instance of the gateway and utilizes its own fetcher for all requests to GCS. The global fetcher was fortunately not depended on by anything else, so the change is relatively minimal. I made a few consolidations so as not to pass the fetcher around between many small functions. The functions I removed were one-time use, relatively small, and may have added negligible amounts of indirection anyway. Apollo-Orig-Commit-AS: apollographql/apollo-server@48c9e3e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state, the gateway uses a global fetcher, meaning the
fetcher and its cache is shared among all gateways within the same
runtime. This change attaches a single fetcher to the instance of the
gateway and utilizes its own fetcher for all requests to GCS. The
global fetcher was fortunately not depended on by anything else, so
the change is relatively minimal.
I made a few consolidations so as not to pass the fetcher around between
many small functions. The functions I removed were one-time use, relatively
small, and may have added negligible amounts of indirection anyway.