gateway(feat): Allow complete SDL - follow-up to #4209 #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional normalization to composition inputs in order to prevent duplicate directive errors when constructing the schema. The oversight from #4209 that's being corrected by this commit is to _also_ remove specified directive definitions (to be included by the composition work itself). Failure to remove them during composition results in duplicate definitions and graphql validation errors.
trevor-scheer
force-pushed
the
trevor/normalization-strip-default-directives
branch
from
0f9d9dc to
a97a502
Compare
|
What about common custom directives in federation schema? |
|
@tapaderster a good question! Composition actually already handles this, if you take a look at this #3536. Currently the type system directives are ignored by composition altogether (meaning they're supported, just implemented at the service level). See also #3464 for details on executable directives, which are also supported by the gateway but with some caveats. |
jbaxleyiii
approved these changes
Jun 11, 2020
abernix
approved these changes
Jun 11, 2020
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…-server#4209 (apollographql/apollo-server#4228) This commit adds additional normalization to composition inputs in order to prevent duplicate directive errors when constructing the schema. The oversight from apollographql/apollo-server#4209 that's being corrected by this PR is to also remove specified directive definitions (@deprecated, @Skip, @include, and @SpecifiedBy) from composition inputs. Failure to remove them during composition results in duplicate definitions and graphql validation errors if they are included in the composition inputs. Apollo-Orig-Commit-AS: apollographql/apollo-server@672fb1b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional normalization to composition inputs in order to prevent duplicate directive errors when constructing the schema.
The oversight from #4209 that's being corrected by this PR is to also remove specified directive definitions (
@deprecated,@skip,@include, and@specifiedBy) from composition inputs. Failure to remove them during composition results in duplicate definitions and graphql validation errors if they are included in the composition inputs.