Skip to content

fix: wrap deprecated functions with util.deprecate() #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

dnalborczyk
Copy link
Contributor

fixes #1025

@dnalborczyk dnalborczyk marked this pull request as ready for review September 30, 2021 19:17
@trevor-scheer
Copy link
Contributor

Thanks @dnalborczyk! Could you please add entries to the gateway and federation CHANGELOG.mds? Providing instructions for how to silence these warnings would be great for our users who start to see these unexpectedly in their logs. I'll take care of this next week if you don't get around to it.

Side note, maybe it's time I just kill these deprecated bits :)

@dnalborczyk
Copy link
Contributor Author

dnalborczyk commented Oct 4, 2021

Providing instructions for how to silence these warnings would be great for our users who start to see these unexpectedly in their logs.

do you want me to add silencing instructions to the changelog?

Side note, maybe it's time I just kill these deprecated bits :)

if you feel it's time to nuke the deprecated functions altogether please go ahead 😄 I think breaking things are expected with 0.x versioned packages.

@trevor-scheer
Copy link
Contributor

@dnalborczyk silencing instructions in the changelog would be excellent - I think people surprised by the new messaging will reach to the changelog first to see what's causing the warnings.

Copy link
Contributor

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trevor-scheer trevor-scheer merged commit f2782bb into apollographql:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsdoc @deprecated is not discoverable when compiled with the removeComments flag
2 participants