fix(gateway-js): Default variables to an empty object when not provided #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a query like this:
query MyQuery($arg: Int) {
myQuery(arg: $arg)
}
In case the arg variable is not provided on
the GraphQL request, even though it's not required,
the Gateway would crash, since it would try
to coearce a nullish variables object.
This behavior is not expected behavior,
since the GraphQL-JS library handle this
nicely [1].
In order to prevent further crashes, a check
was added it will simple provide an empty
object to the getVariablesValues(), just
like the original implementationl.
[1]: https://github.com/graphql/graphql-js/blob/d6e760cf7060217bd25fa934bd104ff2400aad96/src/execution/execute.js#L347
|
@cabelitos: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Hey guys, sorry. I did not know that I had to sign the CLA contract. I've just signed. |
bdilly
approved these changes
Sep 22, 2020
|
Hey guys, any news on this one? |
abernix
changed the title
ReproductionGiventype Query {
plan(id: ID): String
}and query Testing($arg:ID) {
plan(id:$arg)
}Then$ curl 'http://endpoint/graphql' \
-H 'Content-Type: application/json' \
--data-binary '{
"query": "query Testing($arg:ID) { plan(id:$arg) }"
}'Yields{"errors":[{"message":"Cannot convert undefined or null to object","extensions":{"code":"INTERNAL_SERVER_ERROR"}}]} |
abernix
approved these changes
Sep 30, 2020
|
@abernix thank you for the support! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a query like this:
In case the arg variable is not provided on
the GraphQL request, even though it's not required,
the Gateway would crash, since it would try
to coearce a nullish variables object.
This behavior is not expected,
since the GraphQL-JS library handle this
nicely (see https://github.com/graphql/graphql-js/blob/d6e760cf7060217bd25fa934bd104ff2400aad96/src/execution/execute.js#L347).
In order to prevent further crashes, a check
was added it will simple provide an empty
object to the getVariablesValues(), just
like the original implementationl.
Closes #196