FIX: Minifying a String argument should escape quotes and slashes #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 21, 2020 11:36
…shes fixes #170 This was a regression with the new Rust query planner; the minified implementation has a bug where if a String argument contains either `\` character or a `"` character, they should be printed with escaping so that the eventual operation string is valid. Test cases were added to ensure we don't regress. I've verified they fail without the fix.
Enrico2
changed the title
trevor-scheer
approved these changes
Sep 21, 2020
Enrico2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #170
This was a regression with the new Rust query planner; the minified implementation has a bug where if a String argument contains either
\character or a"character, they should be printed with escaping so that the eventual operation string is valid.Test cases were added to ensure we don't regress. I've verified they fail without the fix.
Unrelated: Update license in Cargo.toml, this was wrong initially.