Skip to content

Fix missing sources computation for composition hints/errors #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix missing sources computation for composition hints/errors #3075

merged 1 commit into from
Jul 11, 2024

Conversation

sachindshinde
Copy link
Contributor

@sachindshinde sachindshinde commented Jul 11, 2024 •
edited
Loading

This PR fixes the issue identified in this review comment. Specifically, this PR fixes the bug in composition hint/error message generation where missing sources were computed incorrectly. (No changeset needed since the referenced PR hasn't been released yet.)

@sachindshinde sachindshinde requested a review from a team as a code owner July 11, 2024 00:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 94f5ed9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde sachindshinde merged commit 2048ae4 into version-2.8.3-beta Jul 11, 2024
12 of 13 checks passed
@sachindshinde sachindshinde deleted the sachin/fix-missing-sources-in-mismatch-reporting branch July 11, 2024 00:02
@sachindshinde sachindshinde restored the sachin/fix-missing-sources-in-mismatch-reporting branch July 11, 2024 00:13
@sachindshinde sachindshinde mentioned this pull request Jul 11, 2024
Merged
sachindshinde added a commit that referenced this pull request Jul 11, 2024
@sachindshinde
Create changeset for #3075 (#3076)
f376447 
This PR adds a changeset file for #3075 (even though it's not really
necessary for the eventual patch release, it turns out we need it for
the changesets GH action to auto-file the PR).
@sachindshinde sachindshinde deleted the sachin/fix-missing-sources-in-mismatch-reporting branch July 11, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sachindshinde