fix(gateway): Address typings issue for getDefaultFetcher
#585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
The code change is fine (I looked at the CI-produced tarballs and the output looks like it used to in dist/index.d.ts).
I think that you either want to separate the changelog into explicit alpha.1 and alpha.0 sections, or just want to leave out the new changelog entry entirely and perhaps add a reference to this PR #585 to the end of the existing line (since basically this is just a fix for that PR)
trevor-scheer
commented
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Fetchertype isn't quite right here (it's augmented with.defaults()later in its exported life, which is more applicable to our use case.More importantly, the compiled types lose the following important line in
index.d.ts/// <reference path="../src/make-fetch-happen.d.ts" />...when the
Fetchertype (ortypeof fetcher) is used to declare the return type ofgetDefaultFetcher.For now, leaving this off is more correct and inferrable by TS anyhow.