Remove undefined entities when executing Fetch of query plan
#612
+338
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ordering should be preserved
If a parent fetch hasn't returned a value for an entity (because of a type condition for example), or has explicitly returned null, we want to filter out these entities before continuing with the fetch. If there are no entities left we avoid the fetch altogether, but otherwise we'll perform the fetch with just the remaining entities.
abernix
reviewed
Mar 29, 2021
abernix
requested changes
Mar 30, 2021
Co-authored-by: Jesse Rosenberger <[email protected]>
Co-authored-by: Jesse Rosenberger <[email protected]>
…s, too. e.g. `const reviews` => `export const reviewsData`, `const products` => `export const productsData`. Someone will want this eventually.
These tests have been factored differently now.
abernix
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a given query will select concrete types that implement an interface, which in turn generates a query plan to be executed across the selected types to downstream services. In executing the query plan, it is possible to have an array of entities that are undefined. In the case of an undefined entity, we currently still send the request to the downstream service when we should return.
This PR introduces the idea of removing undefined entities prior to checking if the
entitiesarray is greater than 0.