Skip to content

chore(federation): Rename buildFederatedSchema -> buildSubgraphSchema #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2021

Conversation

trevor-scheer
Copy link
Contributor

This deprecates but continues to support usages of buildFederatedSchema
by exporting an alias of the existing function.

The naming of this fn has always been slightly confusing, but since the
introduction of the word subgraph, this seems like a very sensible rename.

@trevor-scheer
Copy link
Contributor Author

A search of 'federated' within the codebase reveals a lot of documentation that could be migrated to 'subgraph' cc @StephenBarlow.

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the remaining instances of "federated", and they all appear to describe an entire "federated graph" or a supergraph schema, both of which feel fine. So at least from a docs perspective, think this is good!

@glasser
Copy link
Member

glasser commented Aug 2, 2021

Not reviewing but I love this idea.

This deprecates but continues to support usages of
buildFederatedSchema by exporting an alias of the
existing function.
@trevor-scheer trevor-scheer force-pushed the trevor/buildFederatedSchema-rename branch from 863bba5 to 7ab33ba Compare August 6, 2021 18:13
@trevor-scheer trevor-scheer enabled auto-merge (squash) August 6, 2021 18:18
@trevor-scheer trevor-scheer disabled auto-merge August 6, 2021 18:37
@trevor-scheer trevor-scheer enabled auto-merge (squash) August 6, 2021 18:44
@trevor-scheer trevor-scheer merged commit 5c79632 into main Aug 6, 2021
@trevor-scheer trevor-scheer deleted the trevor/buildFederatedSchema-rename branch August 6, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants