Add "external mu" variant of ML-DSA (65 and 87) in _CryptoExtras
#358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts)" This reverts commit e9de693.
…nts)" This reverts commit e9de693.
…ft-crypto into mldsa-external-mu
fpseverino
changed the title
_CryptoExtras
fpseverino
commented
Jun 18, 2025
Comment on lines
-28
to
-34
|
|
||
| @_implementationOnly import CCryptoBoringSSL | ||
| #if canImport(FoundationEssentials) | ||
| import FoundationEssentials | ||
| #else | ||
| import Foundation | ||
| #endif |
There was a problem hiding this comment.
These imports were duplicated in the same file
Comment on lines
+35
to
+36
| public func signature(forPrehashedMessageRepresentative mu: some DataProtocol) throws -> Data { | ||
| try self.signature_boring(forPrehashedMessageRepresentative: mu) |
There was a problem hiding this comment.
The public method here and the equivalent package one defined in Crypto/Signatures/MLDSA.swift must have different names, otherwise the compiler thinks we are calling the same method and throws the warning Function call causes an infinite recursion.
|
|
||
| private var boringSSLKey: OpenSSLMLDSAPublicKeyImpl<MLDSA65> { | ||
| get throws { | ||
| self.impl is OpenSSLMLDSAPublicKeyImpl<MLDSA65> |
There was a problem hiding this comment.
This throws the warning 'is' test is always true, should we use #if checks instead?
There was a problem hiding this comment.
I've updated it to use #if checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "external mu" variant of the ML-DSA API (65 and 87 variants) in
_CryptoExtras.Checklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
BoringSSL now has an “external mu” variant of the ML-DSA API, which makes it possible to calculate the hash (called “mu”) of the message, context and public key separately, and then pass this “mu” to a signing function.
Basically, it is the same process as the traditional signature function, but separated into two steps.
This is supposed to be the alternative to the HashML-DSA algorithm, which does pure pre-hashing.
Modifications:
Add the "external mu" API to
MLDSA65andMLDSA87when importing_CryptoExtras, add tests.Result:
The "external mu" variant of ML-DSA is now available in
_CryptoExtras.