Skip to content

304 Not Modified Broken with Response Compression Enabled #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2024
+13 −0
Merged

304 Not Modified Broken with Response Compression Enabled #2737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4996e6a
Fixed an issue where HTTP/2 connections would disconnect if response …
dimitribouniol Jun 10, 2024
95fe7c4
Added HTTP encoder tests for 304 Not Modified responses
dimitribouniol Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/NIOHTTP1/HTTPTypes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,7 @@ public enum HTTPResponseStatus: Sendable {
.switchingProtocols,
.processing,
.noContent,
.notModified,
.custom where (code < 200) && (code >= 100):
return false
default:
Expand Down
12 changes: 12 additions & 0 deletions Tests/NIOHTTP1Tests/HTTPResponseEncoderTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ class HTTPResponseEncoderTests: XCTestCase {
writtenData.assertContainsOnly("HTTP/1.1 204 No Content\r\ncontent-length: 0\r\n\r\n")
}

func testNoContentLengthHeadersFor304() throws {
let headers = HTTPHeaders([("content-length", "0")])
let writtenData = sendResponse(withStatus: .notModified, andHeaders: headers)
writtenData.assertContainsOnly("HTTP/1.1 304 Not Modified\r\n\r\n")
}

func testNoTransferEncodingHeadersFor101() throws {
let headers = HTTPHeaders([("transfer-encoding", "chunked")])
let writtenData = sendResponse(withStatus: .switchingProtocols, andHeaders: headers)
Expand Down Expand Up @@ -153,6 +159,12 @@ class HTTPResponseEncoderTests: XCTestCase {
writtenData.assertContainsOnly("HTTP/1.1 204 No Content\r\ntransfer-encoding: chunked\r\n\r\n")
}

func testNoTransferEncodingHeadersFor304() throws {
let headers = HTTPHeaders([("transfer-encoding", "chunked")])
let writtenData = sendResponse(withStatus: .notModified, andHeaders: headers)
writtenData.assertContainsOnly("HTTP/1.1 304 Not Modified\r\n\r\n")
}

func testNoChunkedEncodingForHTTP10() throws {
let channel = EmbeddedChannel()
defer {
Expand Down