Skip to content

Conflict grpc package name and message name #2176

Closed
@alicialics

Description

@alicialics

Describe the bug
When the package name matches one of the grpc message we get an error

/* This is an auto generated file. Please do not change it. */
syntax = "proto3";
package foo;
service BamService {
    rpc GetFOOs (GetFOOsRequest) returns (GetFOOsResponse) {}
}

message GetFOOsRequest {
    int32 id = 1;
}
message FOO {
    int64 id = 1;
}
message GetFOOsResponse {
    repeated FOO foos = 1;
}
🕸️ =>  ✖ Unable to start GraphQL Mesh: TypeError[GetFoOsResponse.foos]: Syntax Error: Expected Name, found "]".

the error may be fixed in one of the two ways:
Change message FOO { to something else, like Foo or FAA
Change GetFOOsResponse to something else, like GetFoosResponse or GetFAAsResponse
Change package name from foo to something else

Screen Shot 2021-05-18 at 5 10 38 PM

Similar to #1719

To Reproduce
Code sandbox: https://codesandbox.io/s/vigorous-shtern-8stbo

Expected behavior
no error when running yarn mesh

Environment:

"@graphql-mesh/cli": "0.29.13",
"@graphql-mesh/graphql": "0.17.8",
"@graphql-mesh/grpc": "0.14.7",
"graphql": "15.5.0"

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions