Skip to content

In interpolator, applyRule function does not replace an argument if "dataToReplace" is 0 #5817

Closed
@WeizhengSap

Description

@WeizhengSap

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

Make sure to fork this template and run yarn generate in the terminal.

Please make sure Mesh package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

In Interpolator.js, function applyRule has:

  applyRule(str, rule, data = {}) {
    const dataToReplace = this.applyData(rule.key, data);
    if (dataToReplace) {
      return str.replace(rule.replace, this.applyModifiers(rule.modifiers, dataToReplace, data));
    } else if (rule.alternativeText) {
      return str.replace(
        rule.replace,
        this.applyModifiers(rule.modifiers, rule.alternativeText, data),
      );
    }

    const defaultModifier = this.applyModifiers(rule.modifiers, rule.key, data);
    if (defaultModifier === rule.key) {
      return str.replace(rule.replace, '');
    }
    return str.replace(rule.replace, defaultModifier);
  }

So, when dataToReplace is 0, str.replace(rule.replace, '') will be returned.

To Reproduce Steps to reproduce the behavior:

parse string /users/{args.userId}/carts/{args.cartId}/entries/{args.entryNumber}, data is

{ 
  args: {
     cartId: '00001017',
     entryNumber: 0,
     userId: 'current'
  }
}

expected result is: /users/current/carts/00001017/entries/0
but what we got is: /users/current/carts/00001017/entries

Expected behavior

Environment:

  • OS:
  • @graphql-mesh/...:
  • NodeJS:

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions