Skip to content

fix: faker dynamicValues data generation #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix: faker dynamicValues data generation #96

merged 3 commits into from
Sep 29, 2022

Conversation

JimmyPaolini
Copy link
Collaborator

Fixing a small typo where arguments were passed to the wrong function in a chain.

ardeois
ardeois approved these changes Sep 29, 2022
View reviewed changes
Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but don't forget to update unit tests

@ardeois ardeois added the patch Increment the patch version when merged label Sep 29, 2022
@ardeois ardeois merged commit cc8f500 into ardeois:main Sep 29, 2022
@MH4GF
Copy link
Contributor

MH4GF commented Sep 30, 2022

@JimmyPaolini Oh, thanks for finding it! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardeois ardeois ardeois approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimmyPaolini @MH4GF @ardeois