fix: added pagination to the workflow and pod listings. Fixes #14374 #14373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isubasinghe
changed the title
Signed-off-by: isubasinghe <[email protected]>
isubasinghe
force-pushed
the
feat-paginate-list-calls
branch
from
f24b256 to
dc39ddb
Compare
isubasinghe
changed the title
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
isubasinghe
changed the title
Signed-off-by: isubasinghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14374
Motivation
This change ensures that pagination happens in our list calls to both pod and workflows. This is needed because when k8s has a large number of resources, it is generally better to perform some amount of pagination.
Modifications
Simple change that modified the list calls to use 'continue on' tokens.
Verification
Tested to ensure the k8s api calls function as is.