Updates Marlin constraints to latest LC representation #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I’ll ask Weikeng and Nick for reviews because they were the last ones to look at this |
|
Yes, I communicated with Howard on this. I will look into this PR and fix the constraints branches tonight. |
weikengchen
approved these changes
Jan 29, 2021
|
(I will look into Marlin very soon.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Marlin constraints to latest LC representation.
I strongly recommend reviewing poly-commit/src/marlin_pc/constraints#L1882&L1935 to ensure the updates are up to spec, as there are currently no unit tests for constraints.