Skip to content

Update PC::check_combinations to optional rng #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

vlopes11
Copy link
Member

Closes #96

Description

Update PC::check_combinations and PC::batch_check to take the rng as optional. Will fix downstream problems with marlin

closes: #96


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master) - N/A, the purpose is to prepare constraints to be merged
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests - N/A, only preparing to release
  • Updated relevant documentation in the code - N/A, only preparing to release
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md - N/A, only preparing to release
  • Re-reviewed Files changed in the Github PR explorer

@vlopes11 vlopes11 self-assigned this Apr 25, 2022
@weikengchen weikengchen merged commit a688fe9 into constraints Apr 25, 2022
@weikengchen weikengchen deleted the vlopes11/combinations-signature branch April 25, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants