Misc fixes #633
Merged
Misc fixes #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
February 2, 2024 19:05
At priority 0, C memory management is shutdown.
This was causing the previous errno (reported during fixcase) to be reported as effect of Rename rather then error reported in nocase_rename()
Field background is used as storage in GetAttr call and thus must be IPTR
mgi_Prefs have frame fields of count MUIV_Frame_Count. Having MUIV_Frame_Register as higher value than count was causing reading of random memory in zframe->draw. Note: loading and saving of settings for MUIV_Frame_Register is not implemented. This change is backward compatible. ZunePrefsNew is internal and mgi_Prefs pointer from MUI_GlobalInfo is not even exposed in public headers.
Literals are treated as int (32-bit) by default. This causes wrong 64-bit values for negative numbers which are transported via APTR-size fields. Extend the literals to size of long depending on platform.
The assumption of struct ListImage and NList image structure having obj at the same offset is not valid under 64-bits
In C code, p SysBase gives $1 = (struct ExecBase *)addr, however when first C++ debugging information is loaded, this is change into $1 = (ExecBase *)addr. This results in $SysBase = (ExecBase *)addr and gdb complaining about ExecBase type not being known. The hack makes sure that output is always $SysBase = (struct ExecBase*)addr
It now support case where address differ in number of digits and falls back to not displaying any images instead of displaying broken text when the hack fails
Ignore ('*') comes before width and length, not after width. Previous code
was failing where there was * and width.
This version correctly supports 64-bit systems with datasizes fixed at 32 bit integers rather than "longs" as in old version.
|
FYI: some of these commits fix #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of different fixes. Please check each commit for description and rationale.
Build-tested with linux-x86_64