fix: improve setup instructions and enforce consistent GOBIN usage #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when GOBIN was empty, default packages listed in $ASDF_GOLANG_DEFAULT_PACKAGES_FILE were installed to $ASDF_INSTALL_PATH/packages/bin. This could cause confusion, as user-installed binaries might end up in different locations. This commit ensures that GOBIN is always set, so all binaries are consistently installed into $ASDF_INSTALL_PATH/bin. Additionally, the use of $ASDF_INSTALL_PATH/packages/bin is deprecated to prevent inconsistencies. Closes asdf-community#151 Signed-off-by: Marko Kungla <[email protected]>
mkungla
changed the title
|
@kennyp any chance of this being merged soon? |
kennyp
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
closes #151
closes #150