Skip to content

fix: remove "origin" argument from git checkout command #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neerfri
Copy link
Contributor

@neerfri neerfri commented Feb 20, 2025

Hi,

We had a problem using the install action when the ~/.asdf dir is restored from cache.

This is the error we got:

fatal: 'origin' is not a commit and a branch 'v0.15.0' cannot be created from it

From checking git's man page I cloud not understand why the "origin" argument was there to begin with.
I tested this branch in our repos and it's working now properly.

I'll appreciate your help in merging this 🙏

@neerfri neerfri requested a review from jthegedus as a code owner February 20, 2025 11:27
@neerfri neerfri changed the title remove "origin" argument from git checkout command fix: remove "origin" argument from git checkout command Feb 20, 2025
@neerfri neerfri force-pushed the fix-install-action-with-recent-git-cli branch from c742d5e to 1e3bf77 Compare February 20, 2025 11:38
@neerfri
Copy link
Contributor Author

neerfri commented Feb 25, 2025

@Stratus3D I'd appreciate your feedback on this change.

Thank you 🙏

@Stratus3D
Copy link
Member

Hi @neerfri ! Thanks for the PR. I've not worked much on the asdf action, so I am not prepared to review this PR. It does seem odd seeing the remote name listed after the branch. @asdf-vm/core can anyone review this for me?

@neerfri
Copy link
Contributor Author

neerfri commented Mar 6, 2025

Hi guys,
What can be done to get this merged?
Seems from #589 that more users are running into this, probably because of git cli updates

@Stratus3D Can you please point the relevant people to approve this?

Thanks

@Stratus3D
Copy link
Member

@jthegedus can you take a look at this? I've never worked on this action.

@neerfri if there aren't any responses here in the next 2 weeks I'll try to get up to speed on this code and get your PR merged.

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Apologies on the delay.


The failing tests are because the plugins used in testing do not have the DOWNLOAD callback script, which is now a hard requirement as of asdf v0.16, the authors of these plugins will be notified by using this Action once an update is released.

@jthegedus jthegedus merged commit 179e953 into asdf-vm:master Mar 16, 2025
18 of 20 checks passed
@Stratus3D
Copy link
Member

Thanks for validating this change @jthegedus !

@Stratus3D
Copy link
Member

The failing tests are because the plugins used in testing do not have the DOWNLOAD callback script, which is now a hard requirement as of asdf v0.16, the authors of these plugins will be notified by using this Action once an update is released.

Do we have different versions of this action? Some folks have requested the ability to stay on 0.15.x for now as upgrading to 0.16.x will require changes to their code.

@neerfri
Copy link
Contributor Author

neerfri commented Mar 18, 2025

Thanks @jthegedus @Stratus3D 💛

@neerfri neerfri deleted the fix-install-action-with-recent-git-cli branch March 18, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants