-
Notifications
You must be signed in to change notification settings - Fork 44
fix: remove "origin" argument from git checkout command #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove "origin" argument from git checkout command #591
Conversation
c742d5e
to
1e3bf77
Compare
@Stratus3D I'd appreciate your feedback on this change. Thank you 🙏 |
Hi @neerfri ! Thanks for the PR. I've not worked much on the asdf action, so I am not prepared to review this PR. It does seem odd seeing the remote name listed after the branch. @asdf-vm/core can anyone review this for me? |
Hi guys, @Stratus3D Can you please point the relevant people to approve this? Thanks |
@jthegedus can you take a look at this? I've never worked on this action. @neerfri if there aren't any responses here in the next 2 weeks I'll try to get up to speed on this code and get your PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Apologies on the delay.
The failing tests are because the plugins used in testing do not have the DOWNLOAD callback script, which is now a hard requirement as of asdf v0.16
, the authors of these plugins will be notified by using this Action once an update is released.
Thanks for validating this change @jthegedus ! |
Do we have different versions of this action? Some folks have requested the ability to stay on 0.15.x for now as upgrading to 0.16.x will require changes to their code. |
Thanks @jthegedus @Stratus3D 💛 |
Hi,
We had a problem using the install action when the
~/.asdf
dir is restored from cache.This is the error we got:
From checking git's man page I cloud not understand why the "origin" argument was there to begin with.
I tested this branch in our repos and it's working now properly.
I'll appreciate your help in merging this 🙏