Fix debug logging in release #596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debug_build was enabled for users who were using `--compilation_mode=dbg`, which lead to `set -x` being set in the terminal used to create the venv, and tons of logging users don't need to see. The help for the venv tool was also printed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug_build was enabled for users who were using
--compilation_mode=dbg, which lead toset -xbeing set in theterminal used to create the venv, and tons of logging users don't need
to see. The help for the venv tool was also printed.
Now to test this you pass
--@aspect_rules_py//py/private/py_venv:debug_venv=True