Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

JsonInputFormatter and JsonOutputFormatter consistancy #2538

Closed
@JamesNK

Description

@JamesNK

JsonInputFormatter
JsonOutputFormatter

  • On JsonInputFormatter the CreateJsonReader and CreateJsonSerializer method are public and virtual.
  • On JsonOutputFormatter the CreateJsonWriter and CreateJsonSerializer methods are private.

Should these methods be consistent between input and output formatters?

  • JsonOutputFormatter implements IJsonOutputFormatter
  • JsonInputFormatter doesn't implement an interface.

Is IJsonOutputFormatter required? It doesn't have any methods and is only used in one place.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions