Controller helper inconsistency: HttpNotFound(), Ok()

[cottsak]

I can return HttpNotFound() or I can return Ok() from a Controller. Why the inconsistent naming?

It should be one of these two alternatives IMO:

• return HttpNotFound() and return HttpOk(), or
• return NotFound() and return Ok()

I personally prefer the latter like the previous MVC incarnations. Thoughts folks?
cc @JakeGinnivan

[miloush]

I personally prefer the former if that results in the respective HTTP responses, as it is clear from names what it does. I would expect the latter to be application specific.

[cottsak]

To be honest I just want consistency.

[danroth27]

I think we can remove the Http prefixes at this point. I mean, it's all HTTP in MVC, right? HttpNotFound was the method name in MVC 5, but now that we are a v1 product I think we can relax the strict compat constraint.

[rynowak]

Does that include the action result classes?

[codnee]

I agree with @danroth27. The prefix is only making everything more verbose than it needs to be.

[danroth27]

I think the prefix on the result classes is also unnecessary and should be removed, but that's a bigger change. @Eilon ?

[miloush]

@danroth27 While it's all HTTP in MVC, application specific responses might not be in pair with actual HTTP codes (e.g. WebDav). However, like @cottsak I am not strongly opinionated on that, as long as it is consistent.

[Eilon]

I don't feel strongly on renaming the result types. I'm somewhat inclined to say that we keep them as they are now, just to minimize churn.

[codnee]

@Eilon isn't a little churn one of the things you can allow yourself do when creating something from scratch?

[dneimke]

+1 for making them consistent. Agreee with @codnee re. a little churn now to save confusion and frustration later.