This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Fix for https://github.com/aspnet/Mvc/issues/4903. #4907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Haplois, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| @@ -1289,6 +1286,27 @@ internal static object GetModelStateValue(ViewContext viewContext, string key, T | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Adds placeholder attribute to the <paramref name="tagBuilder" />. | |||
|
@Eilon, I'll add appropriate tests today (GMT +02 :)). |
|
@Eilon tests are added. |
|
|
||
| namespace Microsoft.AspNetCore.Mvc.Rendering | ||
| { | ||
| public class HtmlHelperTextBoxAreaTest |
There was a problem hiding this comment.
Rename class to HtmlHelperTextAreaTest and then make filename match.
|
:wait: mostly for a bit of test cleanup |
|
@dougbu I modified the source. |
|
|
thanx very much 
|
@dougbu No worries, glad if I helped. |
| /// <param name="expression">Expression name, relative to the current model.</param> | ||
| protected virtual void AddPlaceholderAttribute( | ||
| ViewDataDictionary viewData, | ||
| TagBuilder tagBuilder, |
There was a problem hiding this comment.
&ğxxhttps://technet.microsoft.com/en-us/sysinternals/ee656415.aspxkjtc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
<textarea>elements.Addresses #4903