[airflow] Move AIR301 to AIR002
#16978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| AIR002 | 113 | 113 | 0 | 0 | 0 |
| AIR301 | 113 | 0 | 113 | 0 | 0 |
ntBre
added
rule
Lee-W
force-pushed
the
move-AIR301-to-AIR201
branch
from
047e0b3 to
fbbbf99
Compare
|
Arguably this even applies to 1.x? Although nobody in their right minds should care about 1.x in 2025. What I’m trying to say is, maybe this makes even more sense as AIR002? |
I thought we're using |
oh, looking into the code again. yep. |
|
probably need to tweak the description a bit. |
Lee-W
changed the title
Lee-W
changed the title
20 tasks
Lee-W
force-pushed
the
move-AIR301-to-AIR201
branch
from
c967397 to
d0ab79f
Compare
dhruvmanila
approved these changes
Mar 31, 2025
crates/ruff_linter/src/rules/airflow/rules/dag_schedule_argument.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/airflow/rules/dag_schedule_argument.rs
Outdated
Show resolved
Hide resolved
dhruvmanila
changed the title
airflow] Move AIR301 to AIR002
Lee-W
force-pushed
the
move-AIR301-to-AIR201
branch
from
d0ab79f to
6f49dc2
Compare
unlike other AIR3XX, this best practice can be applied to Airflow 2 as well. Thus, we think it might make sense for use to move it to AIR2xx so that we the first number of the error align to Airflow version as possible to reduce confusion
Lee-W
force-pushed
the
move-AIR301-to-AIR201
branch
from
6f49dc2 to
55c2995
Compare
dcreager
added a commit
that referenced
this pull request
Apr 3, 2025
* origin/main: (35 commits) [red-knot] Callable types are disjoint from literals (#17160) [red-knot] Fix inference for `pow` between two literal integers (#17161) [red-knot] Add GitHub PR annotations when mdtests fail in CI (#17150) [red-knot] Fix equivalence of differently ordered unions that contain `Callable` types (#17145) [red-knot] Add initial set of tests for unreachable code (#17159) [`airflow`] Move `AIR302` to `AIR301` and `AIR303` to `AIR302` (#17151) ruff_db: simplify lifetimes on `DiagnosticDisplay` [red-knot] Detect division-by-zero in unions and intersections (#17157) [`airflow`] Add autofix infrastructure to `AIR302` name checks (#16965) [`flake8-bandit`] Mark `str` and `list[str]` literals as trusted input (`S603`) (#17136) [`airflow`] Add autofix for `AIR302` attribute checks (#16977) [`airflow`] Extend `AIR302` with additional symbols (#17085) [`airflow`] Move `AIR301` to `AIR002` (#16978) [`airflow`] Add autofix for `AIR302` method checks (#16976) ruff_db: switch diagnostic rendering over to `std::fmt::Display` [red-knot] Add 'Goto type definition' to the playground (#17055) red_knot_ide: update snapshots red_knot_python_semantic: remove comment about `TypeCheckDiagnostic` ruff_db: delete most of the old diagnostic code red_knot: use `Diagnostic` inside of red knot ...
maxmynter
pushed a commit
to maxmynter/ruff
that referenced
this pull request
Apr 3, 2025
## Summary Unlike other AIR3XX rules, this best practice can be applied to Airflow 1 and Airflow 2 as well. Thus, we think it might make sense for use to move it to AIR002 so that the first number of the error align to Airflow version as possible to reduce confusion ## Test Plan the test fixture has been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unlike other AIR3XX rules, this best practice can be applied to Airflow 1 and Airflow 2 as well. Thus, we think it might make sense for use to move it to AIR002 so that the first number of the error align to Airflow version as possible to reduce confusion
Test Plan
the test fixture has been updated